-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new dependencies of spacy-models #28345
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
5d63c4f
to
aa2910c
Compare
recipes/curated-tokenizers/patches/0001-use-our-own-sentencepiece-abseil.patch
Outdated
Show resolved
Hide resolved
recipes/curated-tokenizers/patches/0001-use-our-own-sentencepiece-abseil.patch
Outdated
Show resolved
Hide resolved
recipes/curated-tokenizers/patches/0001-use-our-own-sentencepiece-abseil.patch
Outdated
Show resolved
Hide resolved
@conda-forge/help-python
The versions are chosen here to satisfy the pins in conda-forge/spacy-models-feedstock#7, now after conda-forge/sentencepiece-feedstock#59 also on windows (there's a spurious failure in conda-build, but that shouldn't make a concern for the content of the PR). Please let me know if you have any comments. CC @conda-forge/spacy @conda-forge/spacy-models |
Windows is running into conda/conda-build#5416 |
Remaining failure on windows is due to building a |
Thanks for the review! |
For conda-forge/spacy-models-feedstock#7