Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new dependencies of spacy-models #28345

Merged
merged 7 commits into from
Nov 29, 2024
Merged

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Nov 24, 2024

Copy link
Contributor

github-actions bot commented Nov 24, 2024

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/spacy-curated-transformers/meta.yaml:

    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/spacy. Please ask them to comment on this PR if they are.
  • recipes/curated-tokenizers/meta.yaml:

    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/spacy. Please ask them to comment on this PR if they are.
  • recipes/spacy-pkuseg/meta.yaml:

    • lints:
      • Feedstock with the same name exists in conda-forge.
      • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/spacy. Please ask them to comment on this PR if they are.
  • recipes/curated-transformers/meta.yaml:

    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/spacy. Please ask them to comment on this PR if they are.

@conda-forge-admin

This comment was marked as outdated.

@conda-forge-admin

This comment was marked as outdated.

@conda-forge-admin

This comment was marked as outdated.

@conda-forge-admin

This comment was marked as outdated.

@h-vetinari h-vetinari changed the title add spacy-curated-tokenizers add new dependencies of spacy-models Nov 24, 2024
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 24, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/spacy-curated-transformers/meta.yaml, recipes/curated-tokenizers/meta.yaml, recipes/curated-transformers/meta.yaml, recipes/spacy-pkuseg/meta.yaml) and found it was in an excellent condition.

@h-vetinari h-vetinari force-pushed the sct branch 3 times, most recently from 5d63c4f to aa2910c Compare November 25, 2024 00:19
@h-vetinari
Copy link
Member Author

@conda-forge/help-python
Newer spacy-models versions have new dependencies that aren't in conda-forge yet, specifically:

  • spacy-curated-transformers, which itself depends on
    • curated-transformers
    • curated-tokenizers
  • spacy-pkuseg

The versions are chosen here to satisfy the pins in conda-forge/spacy-models-feedstock#7, now after conda-forge/sentencepiece-feedstock#59 also on windows (there's a spurious failure in conda-build, but that shouldn't make a concern for the content of the PR). Please let me know if you have any comments.

CC @conda-forge/spacy @conda-forge/spacy-models

@h-vetinari
Copy link
Member Author

Windows is running into conda/conda-build#5416

@h-vetinari
Copy link
Member Author

Remaining failure on windows is due to building a noarch: python package and then running into the lack of pytorch on windows.

@h-vetinari
Copy link
Member Author

Thanks for the review!

@h-vetinari h-vetinari merged commit 723de29 into conda-forge:main Nov 29, 2024
4 of 7 checks passed
@h-vetinari h-vetinari deleted the sct branch November 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants